-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added: housekeeping code for addons/packages #323
Conversation
@jmarshallnz; all your comments taken into consideration. ok to pull? |
for (std::map<CStdString,CFileItemList*>::iterator it = packs.begin(); | ||
it != packs.end();++it) | ||
{ | ||
if (it->second.Size() > 1) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Regardless of disk space, I'd personally like to always preserve the two most recent versions per addon, to always have the ability to rollback. I'm comfortable enough that two broken releases in a row are quite unlikely. One suggestion: if that's not done somewhere else already, use this function to delete the packages of uninstalled addons? |
hmm.. i sorta agree and sorta disagree. i guess we could change the space limit to be a 'desired max', while allowing more usage to keep two archives around of all. i was pondering using it to nuke uninstalled addons. but sometimes quick re-adding is also nice. other opinions on that around? i'm fine with going with the consensus.. |
Was guessing why a backup was big&slow, just figured addons/packages grew to 830MB over the time... |
@cptspiff will this go in at any point, my macmini would love you for it.. it has years of updates :) |
i have done what I am willing to do but it was rejected as can be seen from the comments here. |
@cptspiff |
crystal p is not satisfied. |
Maybe an ifdef for certain platforms? look at ATV2, lots of questions on the forum about having no space and us pointing out to clean up (it's on the wiki but still) (same goes for higher database revs on upgrade, the old ones stay behind and fill up fast on big databases, but thats off-topic) |
We NEED this for Frodo. Even if it defaults to off and is turned on in advancedsettings.xml |
@CrystalP, popular demand.. can be revised later. |
added: housekeeping code for addons/packages
this does housekeeping, trying to never go above a given folder size (200MB by default).