Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added: housekeeping code for addons/packages #323

Merged
1 commit merged into from Oct 2, 2012
Merged

added: housekeeping code for addons/packages #323

1 commit merged into from Oct 2, 2012

Conversation

ghost
Copy link

@ghost ghost commented Aug 3, 2011

this does housekeeping, trying to never go above a given folder size (200MB by default).

@ghost
Copy link
Author

ghost commented Aug 4, 2011

@jmarshallnz; all your comments taken into consideration. ok to pull?

for (std::map<CStdString,CFileItemList*>::iterator it = packs.begin();
it != packs.end();++it)
{
if (it->second.Size() > 1)

This comment was marked as spam.

@CrystalP
Copy link
Contributor

CrystalP commented Aug 7, 2011

Regardless of disk space, I'd personally like to always preserve the two most recent versions per addon, to always have the ability to rollback. I'm comfortable enough that two broken releases in a row are quite unlikely.

One suggestion: if that's not done somewhere else already, use this function to delete the packages of uninstalled addons?

@ghost
Copy link
Author

ghost commented Aug 8, 2011

hmm.. i sorta agree and sorta disagree. i guess we could change the space limit to be a 'desired max', while allowing more usage to keep two archives around of all.

i was pondering using it to nuke uninstalled addons. but sometimes quick re-adding is also nice. other opinions on that around? i'm fine with going with the consensus..

@vguerci
Copy link

vguerci commented Mar 4, 2012

Was guessing why a backup was big&slow, just figured addons/packages grew to 830MB over the time...
I'll give it a try and hope it will be merged some day :)
EDIT: Works perfectly, dropped to 166MB as expected, thanks @cptspiff

@amet
Copy link
Contributor

amet commented Sep 10, 2012

@cptspiff will this go in at any point, my macmini would love you for it.. it has years of updates :)

@ghost
Copy link
Author

ghost commented Sep 10, 2012

i have done what I am willing to do but it was rejected as can be seen from the comments here.

@MartijnKaijser
Copy link
Member

@cptspiff
I can't see any comments on why it couldn't be merged or am i missing something?
With the merging an small form HTPC like rpi and the android boxes this would be a very welcome addition to clean disk space

@ghost
Copy link
Author

ghost commented Sep 10, 2012

crystal p is not satisfied.

@jester-xbmc
Copy link

Maybe an ifdef for certain platforms? look at ATV2, lots of questions on the forum about having no space and us pointing out to clean up (it's on the wiki but still) (same goes for higher database revs on upgrade, the old ones stay behind and fill up fast on big databases, but thats off-topic)

@NedScott
Copy link
Contributor

NedScott commented Oct 1, 2012

We NEED this for Frodo. Even if it defaults to off and is turned on in advancedsettings.xml

@ghost
Copy link
Author

ghost commented Oct 2, 2012

@CrystalP, popular demand.. can be revised later.

ghost pushed a commit that referenced this pull request Oct 2, 2012
added: housekeeping code for addons/packages
@ghost ghost merged commit ed0641f into xbmc:master Oct 2, 2012
tru pushed a commit to plexinc/plex-home-theater-public that referenced this pull request Jan 11, 2013
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature non-breaking change which adds functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants